-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritize index.css over the implicit App.css #2470
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
That’s a good catch. |
* Update Travis CI Node versions in User Guide (facebook#2454) Removed Node v4 (CRA only supports Node >= 6) * re-add storybook && update the documentation and links (facebook#2331) * re-add storybook && update the documentation and links * Change to new documentation domain * Prioritize index.css over the implicit App.css (facebook#2470) * Added NamedModulesPlugin in webpack.config.dev.js (facebook#2458) * Added NamedModulesPlugin in webpack.config.dev.js * Update webpack.config.dev.js * Unscope detect-port (facebook#2483) Resolves facebook#2481 * Update webpack links to point to webpack 2 (facebook#2492) * Update README.md to make links to webpack point to webpack.js.org instead insteade of webpack 1 webpack.githup.io * chore(templates): Move GitHub templates to hidden .github folder (facebook#2489) * Fix minor docs typo (facebook#2500) * Fix link to Storybook docs (facebook#2521) * Simplify flow init docs (facebook#2522) - Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`
Fixed in latest version. Please verify. |
Hi. I'm under the assumption that
index.css
is used for global styles not associated with any component. This is where I import 3rd party css libraries as well. However, I noticed that it would override the styles inApp.css
.